List:Commits« Previous MessageNext Message »
From:Stewart Smith Date:November 12 2007 3:38am
Subject:Re: [patch 09/11] Cleanup AsyncFile, make modular and nice to read
View as plain text  
On Fri, 2007-11-09 at 10:00 +0100, Tomas Ulin wrote:
> this cleanup I suggest doing in 5.1-new-ndb to keep code harmonized

The next step is to use different AsyncFile implementations for
different files, and then have a NullAsyncFile that implements diskless
(except for the backup files... so we can have backup of diskless). This
means some parts will quite largely diverge...

So I think I'd prefer to keep all the changes in -telco as I think
things are going to get different enough anyway to have the re-org here
not of too much use...

> stewart@stripped wrote:
> > Move all platform specific AsyncFile functionality out into sep classes.
> >
> > Generic functionality in AsyncFile, POSIX specific in PosixAsyncFile.
> >
> > In future, will have azioAsyncFile (maybe a mysysAsyncFile) and can have
> > specific numbers of each instantiated in kernel. Then, NDBFS can decide
> > which AsyncFile should be used for that file - e.g. we can keep the number
> > of azioAsyncFiles to a minimum.

-- 
Stewart Smith, Senior Software Engineer
MySQL AB, www.mysql.com
Office: +14082136540 Ext: 6616
VoIP: 6616@stripped
Mobile: +61 4 3 8844 332

Jumpstart your cluster:
http://www.mysql.com/consulting/packaged/cluster.html

Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc
Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc
Thread
[patch 00/11] WL4081 NDB Compressed LCP and Backupstewart9 Nov
  • [patch 04/11] WL4081: read compressed backup filesstewart9 Nov
  • [patch 03/11] WL4081: Add compressed file support to AsyncFile (azio) and support compressed backups.stewart9 Nov
  • [patch 01/11] WL4081: Copy azio for NDBstewart9 Nov
  • [patch 05/11] WL4081: add support for *storing* compressed LCPstewart9 Nov
  • [patch 07/11] WL4081 Futz with mtr ndb config to enable compressed lcp, backup and O_DIRECTstewart9 Nov
  • [patch 08/11] WL4081 Allow use of direct IO (O_DIRECT) with aziostewart9 Nov
  • [patch 10/11] Fix mem leak in mgmapi report eventstewart9 Nov
  • [patch 11/11] Massive azio bugfix (mainly for O_DIRECT) and error reportingstewart9 Nov
  • [patch 06/11] WL4081: Add support to AsyncFile for reading zlib compressed files.stewart9 Nov
  • [patch 09/11] Cleanup AsyncFile, make modular and nice to readstewart9 Nov
Re: [patch 10/11] Fix mem leak in mgmapi report eventStewart Smith12 Nov
Re: [patch 08/11] WL4081 Allow use of direct IO (O_DIRECT) withazioStewart Smith12 Nov
Re: [patch 07/11] WL4081 Futz with mtr ndb config to enablecompressed lcp, backup and O_DIRECTStewart Smith12 Nov
Re: [patch 06/11] WL4081: Add support to AsyncFile for readingzlib compressed files.Stewart Smith12 Nov
Re: [patch 09/11] Cleanup AsyncFile, make modular and nice to readStewart Smith12 Nov
Re: [patch 08/11] WL4081 Allow use of direct IO (O_DIRECT)with azioStewart Smith12 Nov