| List: | Commits | « Previous MessageNext Message » | |
| From: | Stewart Smith | Date: | November 12 2007 3:21am |
| Subject: | Re: [patch 08/11] WL4081 Allow use of direct IO (O_DIRECT) with azio | ||
| View as plain text | |||
On Fri, 2007-11-09 at 09:57 +0100, Tomas Ulin wrote: > why not put this in the common azio? A few reasons: 1) Don't break ARCHIVE a) I've kinda broken the flush implementation in a later patch. This is okay for us as we never use it, but ARCHIVE does. b) File format changed slightly - header is now 512bytes so that we can easily operate on it with O_DIRECT without rewriting part of the data file (ick). 2) Fiddling with zlib internals is probably not what we really want to do in too many places. Although I plan to work with Brian at some point to consolidate the two > > stewart@stripped wrote: > > Change azio to either posix_memalign allocate in and out buffers OR > > allow user to allocate these. Flag in azio_stream should be where > > padding was so no additional memory used. > > > > This enables O_DIRECT usage with azio if aligned buffers are allocated > > (by default, the azio allocation - posix_memalign - does this). > > > > Also fiddles with ZLIB internals to get the correct buffer sizes to allocate > > for deflate and inflate. -- Stewart Smith, Senior Software Engineer MySQL AB, www.mysql.com Office: +14082136540 Ext: 6616 VoIP: 6616@stripped Mobile: +61 4 3 8844 332 Jumpstart your cluster: http://www.mysql.com/consulting/packaged/cluster.html Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc
Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc