List:Commits« Previous MessageNext Message »
From:Stewart Smith Date:November 12 2007 3:16am
Subject:Re: [patch 10/11] Fix mem leak in mgmapi report event
View as plain text  
On Fri, 2007-11-09 at 09:55 +0100, Tomas Ulin wrote:
> what is this doing here?

Hiding until I file a bug report and verify... this was giving me extra
valgrind warnings during testing.

> stewart@stripped wrote:
> > ---
> >  storage/ndb/src/mgmapi/mgmapi.cpp |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > Index: telco-6.2/storage/ndb/src/mgmapi/mgmapi.cpp
> > ===================================================================
> > --- telco-6.2.orig/storage/ndb/src/mgmapi/mgmapi.cpp	2007-11-08
> 11:38:56.116444089 +1100
> > +++ telco-6.2/storage/ndb/src/mgmapi/mgmapi.cpp	2007-11-08 11:39:22.117719363
> +1100
> > @@ -2691,6 +2691,7 @@ int ndb_mgm_report_event(NdbMgmHandle ha
> >    prop = ndb_mgm_call(handle, reply, "report event", &args);
> >    DBUG_CHECK_REPLY(handle, prop, -1);
> >  
> > +  delete prop;
> >    DBUG_RETURN(0);
> >  }

-- 
Stewart Smith, Senior Software Engineer
MySQL AB, www.mysql.com
Office: +14082136540 Ext: 6616
VoIP: 6616@stripped
Mobile: +61 4 3 8844 332

Jumpstart your cluster:
http://www.mysql.com/consulting/packaged/cluster.html

Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc
Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc
Thread
[patch 00/11] WL4081 NDB Compressed LCP and Backupstewart9 Nov
  • [patch 04/11] WL4081: read compressed backup filesstewart9 Nov
  • [patch 03/11] WL4081: Add compressed file support to AsyncFile (azio) and support compressed backups.stewart9 Nov
  • [patch 01/11] WL4081: Copy azio for NDBstewart9 Nov
  • [patch 05/11] WL4081: add support for *storing* compressed LCPstewart9 Nov
  • [patch 07/11] WL4081 Futz with mtr ndb config to enable compressed lcp, backup and O_DIRECTstewart9 Nov
  • [patch 08/11] WL4081 Allow use of direct IO (O_DIRECT) with aziostewart9 Nov
  • [patch 10/11] Fix mem leak in mgmapi report eventstewart9 Nov
  • [patch 11/11] Massive azio bugfix (mainly for O_DIRECT) and error reportingstewart9 Nov
  • [patch 06/11] WL4081: Add support to AsyncFile for reading zlib compressed files.stewart9 Nov
  • [patch 09/11] Cleanup AsyncFile, make modular and nice to readstewart9 Nov
Re: [patch 10/11] Fix mem leak in mgmapi report eventStewart Smith12 Nov
Re: [patch 08/11] WL4081 Allow use of direct IO (O_DIRECT) withazioStewart Smith12 Nov
Re: [patch 07/11] WL4081 Futz with mtr ndb config to enablecompressed lcp, backup and O_DIRECTStewart Smith12 Nov
Re: [patch 06/11] WL4081: Add support to AsyncFile for readingzlib compressed files.Stewart Smith12 Nov
Re: [patch 09/11] Cleanup AsyncFile, make modular and nice to readStewart Smith12 Nov
Re: [patch 08/11] WL4081 Allow use of direct IO (O_DIRECT)with azioStewart Smith12 Nov