Re: bk commit into 4.1 tree (svoj:1.2688) BUG#31277

[Sergei Golubchik]

Hi!

On Nov 01, Sergey Vojtovich wrote:
> On Thu, Nov 01, 2007 at 05:06:31PM +0100, Sergei Golubchik wrote:
> > 
> > On Oct 30, Sergey Vojtovich wrote:
> > > ChangeSet@stripped, 2007-10-30 14:36:37+04:00, svoj@stripped +4 -0
> > >   BUG#31277 - myisamchk --unpack corrupts a table
> > >   
> > >   With certain data sets (when compressed record length gets bigger than
> > >   uncompressed) myisamchk --unpack may corrupt data file.
> > 
> > ok, looks good.
> >    
> > >   Fixed that record length was wrongly restored from compressed table.
> > >   
> > >   No test case for this fix, as currently our test suite doesn't support
> > >   execution of myisampack tool.
> > 
> > It can execute any executable of your choice. It can execute
> > mysqldump and mysqlbinlog, I don't see why it cannot execute myisampack.
> > 
> > Could you try to create a test case ?
>
> Yes, it can execute any binary, but it requires tambourine-dances around
> mysql-test-run script to make it portable. Tools like mysqldump are never
> called directly - they use MYSQL_DUMP env variable that is generated by
> mysql-test-run. So we need to implement similiar thing for myisampack and
> myisamchk, which will take some time.

isn't it as simple as adding

  $ENV{'MYISAMPACK'}= mtr_native_path(mtr_exe_exists(
                                vs_config_dirs('storage/myisam', 'myisampack'),
                                "$path_client_bindir/myisampack",
                                "$glob_basedir/storage/myisam/myisampack"));

and the same for myisamchk ?
 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140