List:Commits« Previous MessageNext Message »
From:msvensson Date:March 10 2006 12:08pm
Subject:bk commit into 5.0 tree (msvensson:1.2071)
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2071 06/03/10 12:08:53 msvensson@neptunus.(none) +1 -0
  Improve mysqltest
  Add comment's for enable/disable_query_log and enable/disable_result_log
  Update comment for "check_result"
  Add check in "handle_error" that detects if the server crashed when running a "require"
query to check if a certain feature is available

  client/mysqltest.c
    1.203 06/03/10 12:08:49 msvensson@neptunus.(none) +14 -2
    Add comment's for enable/disable_query_log and enable/disable_result_log
    Update comment for "check_result"
    Add check in "handle_error" that detects if the server crashed when running a
"require" query to check if a certain feature is available

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	neptunus.(none)
# Root:	/home/msvensson/mysql/bug11835/my50-bug11835

--- 1.202/client/mysqltest.c	2006-02-14 15:34:24 +01:00
+++ 1.203/client/mysqltest.c	2006-03-10 12:08:49 +01:00
@@ -393,8 +393,10 @@
   "enable_rpl_parse",
   "disable_rpl_parse",
   "eval_result",
+  /* Enable/disable that the _query_ is logged to result file */
   "enable_query_log",
   "disable_query_log",
+  /* Enable/disable that the _result_ from a query is logged to result file */
   "enable_result_log",
   "disable_result_log",
   "server_start",
@@ -753,8 +755,8 @@
   check_result
   ds - content to be checked
   fname - name of file to check against
-  require_option - if set and check fails, the test will be aborted with the special
-                   exit code "not supported test"
+  require_option - if set and check fails, the test will be aborted
+                   with the special exit code "not supported test"
 
   RETURN VALUES
    error - the function will not return
@@ -3481,7 +3483,17 @@
   DBUG_ENTER("handle_error");
 
   if (q->require_file)
+  {
+    /*
+      The query after a "--require" failed. This is fine as long the server
+      returned a valid reponse. Don't allow 2013 or 2006 to trigger an
+      abort_not_supported_test
+     */
+    if (err_errno == CR_SERVER_LOST ||
+        err_errno == CR_SERVER_GONE_ERROR)
+      die("require query '%s' failed: %d: %s", query, err_errno, err_error);
     abort_not_supported_test();
+  }
 
   if (q->abort_on_error)
     die("query '%s' failed: %d: %s", query, err_errno, err_error);
Thread
bk commit into 5.0 tree (msvensson:1.2071)msvensson10 Mar