Re: bk commit into 5.0 tree (aelkin:1.2543) BUG#28597

[Sergei Golubchik]

Hi!

On Oct 29, Andrei Elkin wrote:
> ChangeSet@stripped, 2007-10-29 13:47:25+02:00, aelkin@stripped +3 -0
>   Bug #28597 Replication doesn't start after upgrading to 5.1.18
>   
>   Since bug@20166, which replaced the binlog file name generating to base
>   on pidfile_name instead of the previous glob_hostname, the binlog file
>   name generating and its storing into the binlog index
>   suddenly started to be solely in the absolute path format,
>   including a case when --log-bin option meant a relative path.
>   
> diff -Nrup a/sql/log.cc b/sql/log.cc
> --- a/sql/log.cc	2007-07-30 18:27:30 +03:00
> +++ b/sql/log.cc	2007-10-29 13:47:22 +02:00
> @@ -821,8 +819,14 @@ int MYSQL_LOG::find_log_pos(LOG_INFO *li
>  			    bool need_lock)
>  {
>    int error= 0;
> +  uint flag= MYF(MY_RETURN_REAL_PATH);
> +  char abs_path_bi[2*FN_REFLEN]; // abs path for binlog index file
> +  char abs_path_lf[2*FN_REFLEN]; // for log file argument
> +
>    char *fname= linfo->log_file_name;
>    uint log_name_len= log_name ? (uint) strlen(log_name) : 0;
> +  if (log_name)
> +    fn_format(abs_path_lf, log_name, mysql_real_data_home, "", flag);
>    DBUG_ENTER("find_log_pos");
>    DBUG_PRINT("enter",("log_name: %s", log_name ? log_name : "NULL"));

Sorry, I don't understand.
We've discussed at length that you should use MY_UNPACK_FILENAME here,
and not MY_RETURN_REAL_PATH. And now you sumbit a new patch with
MY_RETURN_REAL_PATH.

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140