fre 2007-10-26 klockan 16:39 +0200 skrev Guilhem Bichot:
> aha, I didn't know we had append_file, I thought write_file would
> append. But now I realize that that append_file exists and write_file
> will fail if the file exists. With this in mind, there is one places
> of your patch where the old system command used >> and you converted
> it to write_file, which is thus theoretically incorrect:
>
> diff -Nrup a/mysql-test/t/show_check.test b/mysql-test/t/show_check.test
> --- a/mysql-test/t/show_check.test 2007-08-02 15:23:14 +02:00
> +++ b/mysql-test/t/show_check.test 2007-10-22 10:56:23 +02:00
> @@ -427,7 +427,9 @@ DROP TABLE t1;
> flush tables;
>
> # Create a junk frm file on disk
> -system echo "this is a junk file for test" >>
> $MYSQLTEST_VARDIR/master-data/test/t1.frm ;
> +write_file $MYSQLTEST_VARDIR/master-data/test/t1.frm;
> +this is a junk file for test
> +EOF
>
Yes, but looking a t the comment and the code above(where we just drop
t1), I consider the >> a bug. ;)
ok to use "write_file"?
/ Magnus
--
Magnus Svensson
Senior Software Engineer
msvensson@stripped
+46709164491
Attachment: [application/pgp-signature] Detta =?ISO-8859-1?Q?=E4r?= en digitalt signerad
meddelandedel signature.asc
Attachment: [application/pgp-signature] Detta =?ISO-8859-1?Q?=E4r?= en digitalt signerad
meddelandedel signature.asc
