Hi Davi
Davi Arnaut wrote:
> Below is the list of changes that have just been committed into a local
> 5.2 repository of davi. When davi does a push these changes will
> be propagated to the main repository and, within 24 hours after the
> push, to the public repository.
> For information on how to access the public repository
> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
>
> ChangeSet@stripped, 2007-10-19 09:46:34-03:00, davi@stripped +5 -0
> Bug#30904 SET PASSWORD statement is non-transactional
>
> The SET PASSWORD statement is non-transactional (no explicit transaction
> boundaries) in nature and hence is forbidden inside stored functions and
> triggers, but it weren't being effectively forbidden.
>
> The implemented fix is to issue a implicit commit with every SET PASSWORD
> statement, effectively prohibiting these statements in stored functions
> and triggers.
>
>
Delete the paragraph below from the CSET comments,
and add it as comments flagged "Doc team:" in the bug report itself
> Since this is a incompatible change, the following sentence should be
> added to the Manual in the very end of the 3rd paragraph, subclause
> 13.4.3 "Statements That Cause an Implicit Commit": "Beginning with
> MySQL 5.?.??, the SET PASSWORD statement causes an implicit commit."
>
> mysql-test/r/sp-error.result@stripped, 2007-10-19 09:46:25-03:00, davi@stripped
> +10 -0
> Add test case result for Bug#30904
>
> mysql-test/t/sp-error.test@stripped, 2007-10-19 09:46:26-03:00, davi@stripped +19
> -0
> Add test case for Bug#30904
>
> sql/sql_lex.h@stripped, 2007-10-19 09:46:26-03:00, davi@stripped +1 -1
> Add variable to set that a statement with SET PASSWORD causes a implicit
> commit.
>
> sql/sql_parse.cc@stripped, 2007-10-19 09:46:26-03:00, davi@stripped +4 -0
> End active transaction in SET PASSWORD.
>
> sql/sql_yacc.yy@stripped, 2007-10-19 09:46:26-03:00, davi@stripped +8 -0
> Set the correct flag on SET PASSWORD if inside a SP, thus effectively
> prohibiting SET PASSWORD statements in stored functions and triggers.
>
>
Ok to push.
Where to push the fix will be discussed internally, I suggest 5.1
Thanks,
Marc.
