Hallo Sergei,
Thank you for the review!
> 1. Why did you add the check here, and not where CREATE_ACL is
> checked ?
That is a hold-over from original longer patch which implemented
different behaviour. ( http://lists.mysql.com/commits/34326 )
You are of course correct in suggesting that current check could
well go in with create_table_precheck(). Adjust in updated patch;
behaviour same otherwise as per test suite.
http://lists.mysql.com/commits/35863
> 2. do it in 5.1
I can certainly do that. (I presume your rationale is that it
changes existing behaviour? Brian called it "security flaw" so
I figured I'd err on the side of caution and put it in 4.1, 5.0,
5.1, but it's your call. Saves me running the tests thrice, I
guess.) Have up-merged to 5.0, 5.1; will only push to 5.1 then.
thanks/regards,
Tatjana
--
Tatjana A. Nurnberg, Software Developer * MySQL AB, http://www.mysql.de/ * EST
IRC: Azundris * Skype: azundris * MySQL-SIP: 4550 * eMail: azundris@stripped
.de: Firmensitz: MySQL GmbH, Radlkoferstr. 2, D-81373 Muenchen
Geschaeftsfuehrer: Hans von Bell, Kaj Arnoe - HRB Muenchen 162140
