List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:October 15 2007 6:56pm
Subject:Re: bk commit into 5.1 tree (davi:1.2599) BUG#21557
View as plain text  
* Davi Arnaut <davi@stripped> [07/10/15 18:57]:

> ChangeSet@stripped, 2007-10-15 11:01:18-03:00, davi@stripped +8 -0
>   Bug#21557 entries in the general query log truncated at 1000 characters.
>   
>   The general log write function (general_log_print) uses printf style
>   arguments which need to be pre-processed, meaning that the all arguments
>   are copied to a single buffer and the problem is that the buffer size is
>   constant (1022 characters) but queries can be much larger then this.
>   
>   The solution is to introduce a new log write function that accepts a
>   buffer and it's length as arguments. The function is to be used when
>   a formatted output is not required, which is the case for almost all
>   query write-to-log calls.

Looks good. I shall ask Marc to do the second review.

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY
Thread
bk commit into 5.1 tree (davi:1.2599) BUG#21557Davi Arnaut15 Oct
  • Re: bk commit into 5.1 tree (davi:1.2599) BUG#21557Konstantin Osipov15 Oct
  • Re: bk commit into 5.1 tree (davi:1.2599) BUG#21557Marc Alff18 Oct
    • Re: bk commit into 5.1 tree (davi:1.2599) BUG#21557Konstantin Osipov18 Oct