bk commit into 5.1 tree (msvensson:1.2162) BUG#17574

[msvensson]

Below is the list of changes that have just been committed into a local
5.1 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2162 06/03/07 20:35:59 msvensson@shellback.(none) +1 -0
  Bug#17574 Detect cluster start failure and "fail" ndb_* tests
   - Update for 5.1

  mysql-test/mysql-test-run.pl
    1.82 06/03/07 20:35:53 msvensson@shellback.(none) +14 -4
    Remove mtr_error call from ndbcluster_install_slave
    Check if ndbcluster_install_slave failed after it's been called. continu with disabled slave cluster if  --force is used.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	shellback.(none)
# Root:	/home/msvensson/mysql/bug17574/my51-bug17574

--- 1.81/mysql-test/mysql-test-run.pl	2006-03-07 19:48:50 +01:00
+++ 1.82/mysql-test/mysql-test-run.pl	2006-03-07 20:35:53 +01:00
@@ -1563,7 +1563,6 @@
 		 "--core"],
 		"", "", "", "") )
   {
-    mtr_error("Error ndbcluster_install_slave");
     return 1;
   }
 
@@ -1793,9 +1792,20 @@
 
   if ( ndbcluster_install_slave() )
   {
-    # failed to install, disable usage but flag that its no ok
-    $opt_with_ndbcluster_slave= 0;
-    $flag_ndb_slave_status_ok= 0;
+    if ( $opt_force)
+    {
+      # failed to install, disable usage and flag that its no ok
+      mtr_report("ndbcluster_install_slave failed, " .
+		 "continuing without slave cluster");
+      $opt_with_ndbcluster_slave= 0;
+      $flag_ndb_slave_status_ok= 0;
+    }
+    else
+    {
+      print "Aborting: Failed to install ndb cluster\n";
+      print "To continue, re-run with '--force'.\n";
+      mtr_exit(1);
+    }
   }
 
   return 0;