Hi Ingo,
On Friday 12 October 2007, Ingo Strüwing wrote:
>Hi Alexey,
>
>Alexey Kopytov, 11.10.2007 11:33:
>...
>
>> ChangeSet@stripped, 2007-10-11 13:32:57+04:00, kaa@polly.(none) +2 -0
>> Fix for bug #31254: "Max_data_length" truncated / reported wrong
>> (compiler issue ?)
>>
>> Reverted large-file changes from the fix for bug10776. We need to define
>> _LARGE_FILES on AIX to have support for files > 2 GB. Since
>> _LARGE_FILE_API is incompatible with _LARGE_FILES and may be automatically
>> included, we also need a workaround to avoid this conflict.
>
>Can you please fix the changeset comment?
>- shorter lines
>- high-level description of the problem (improper use of compile-time
>flags prevented use of files > 2GB) in front of the solution and
>in-depth technical explanation.
>
OK, fixed in the new patch.
>
>> +/* Workaround for _LARGE_FILES and _LARGE_FILE_API incompatibility on AIX
>> */ +#if defined(_AIX) && defined(_LARGE_FILE_API)
>> +#undef _LARGE_FILE_API
>> +#endif
>
>Might it be a good idea to have a branch with an #error directive for
>the case that _LARGE_FILES is not defined?
>
It does not look like a good idea to me. Largefile support is available on AIX
starting from version 4.2. Though we don't make builds for older versions,
someone somewhere might want to build for platforms without largefile
support.
>Otherwise OK to push. (I assume this is tested on AIX. Or will be reset
>to in-progress if it fails on pushbuild.)
>
Yes, the patch was successfully tested on AIX.
Thanks and regards,
--
Alexey Kopytov, Software Developer
MySQL AB, www.mysql.com
Are you MySQL certified? www.mysql.com/certification
