Hi Alexey,
Alexey Kopytov, 11.10.2007 11:33:
...
> ChangeSet@stripped, 2007-10-11 13:32:57+04:00, kaa@polly.(none) +2 -0
> Fix for bug #31254: "Max_data_length" truncated / reported wrong (compiler issue
> ?)
>
> Reverted large-file changes from the fix for bug10776. We need to define
> _LARGE_FILES on AIX to have support for files > 2 GB. Since _LARGE_FILE_API is
> incompatible with _LARGE_FILES and may be automatically included, we also need a
> workaround to avoid this conflict.
Can you please fix the changeset comment?
- shorter lines
- high-level description of the problem (improper use of compile-time
flags prevented use of files > 2GB) in front of the solution and
in-depth technical explanation.
...
> +/* Workaround for _LARGE_FILES and _LARGE_FILE_API incompatibility on AIX */
> +#if defined(_AIX) && defined(_LARGE_FILE_API)
> +#undef _LARGE_FILE_API
> +#endif
Might it be a good idea to have a branch with an #error directive for
the case that _LARGE_FILES is not defined?
Otherwise OK to push. (I assume this is tested on AIX. Or will be reset
to in-progress if it fails on pushbuild.)
Regards
Ingo
--
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140
