Re: bk commit into 5.1 tree (mattiasj:1.2568) BUG#30695

[Mattias Jonsson]

Hi Ingo,

I will change the NOTE as you suggested.

Thank you for correcting me, and bring clarity on how to write comments.

Regards
Mattias

Ingo Strüwing wrote:
> Hi Mattias,
> 
> Ingo Strüwing, 11.10.2007 10:31:
> ...
>> mattiasj@stripped, 10.10.2007 20:53:
> ...
>>>   NOTE: If the comment is written by an earlier version of the server,
>>>   the corrupted frm-file is still corrupt, drop the table and recreate it.
>>>   (If needed, edit the frm-file manually and replace the apostrophe
>>>   within the comment with a space to allow parsing)
>> Is this comment correct? Don't you fix the crash by below code?
> 
> Ahrg. I did not read the comment careful enough. Sorry. :-(
> 
> Now I suggest to change it for more clarity (IMHO):
> 
> ... the corrupted frm-file is not fixed, but left corrupt. You have to
> manually drop the table and recreate it.
> 
> I am a bit sceptical about public advice to edit a form file. If using
> an inappropriate editor, this may have unpredictable results. Also it is
> quite improbable that such table could have data. As far as I understand
> there is no server version which could successfully open such a file. So
> it could not add data to it. Drop and recreate shouldn't hurt much under
> these circumstances.
> 
> Regards
> Ingo

-- 
Mattias Jonsson, Software Engineer
MySQL AB, www.mysql.com

Are you MySQL certified?  www.mysql.com/certification