Hi Joerg,
On Thursday 11 October 2007, Joerg Bruehe wrote:
>Alexey Kopytov wrote:
>> diff -Nrup a/config/ac-macros/large_file.m4
>> b/config/ac-macros/large_file.m4 ---
>> a/config/ac-macros/large_file.m4 2007-08-01 06:56:48 +04:00
>> +++ b/config/ac-macros/large_file.m4 2007-10-11 13:32:53 +04:00
>> @@ -128,8 +128,14 @@ AC_DEFUN([MYSQL_SYS_LARGEFILE],
>> ac_cv_sys_largefile_source=1 ;;
>> esac])
>>
>> - # AIX 4.2 and later -- do nothing, include standards.h instead.
>> - # this goes for both GNU and IBM C and C++ compilers.
>> + AC_SYS_LARGEFILE_MACRO_VALUE(_LARGE_FILES,
>> + ac_cv_sys_large_files,
>> + [Large files support on AIX-style hosts.],
>> + [case "$host_os" in
>> + # AIX 4.2 and later
>> + aix4.[2-9]* | aix4.1[0-9]* | aix[5-9].* | aix[1-9][0-9]*)
>> + ac_cv_sys_large_files=1 ;;
>> + esac])
>>
> > fi
> > ])
>
>While I understand the approach of reverting the change that caused it,
>I am not happy with that list of AIX version patterns - it raises the
>impression we were supporting these platforms.
>
>As this fix deals with MySQL 5.0 and up, the only AIX versions we
>support are AIX 5.2 and up. (With MySQL 4.1, we still support AIX 4.3.)
>
>IMO, the list should read either (because we build there)
>
> > + [case "$host_os" in
> > + # AIX 5.2 and later
> > + aix5.[2-9]* | aix[6-9].* )
> > + ac_cv_sys_large_files=1 ;;
> > + esac])
>
>or (a bit easier, and hopefully correct - all AIX 5 should be similar)
>
> > + [case "$host_os" in
> > + # AIX 5 and later
> > + aix[5-9].* )
> > + ac_cv_sys_large_files=1 ;;
> > + esac])
>
>or (for simplicity, without claiming support)
>
> > + [case "$host_os" in
> > + # any AIX - but tested only on 5.2 and up
> > + aix* )
> > + ac_cv_sys_large_files=1 ;;
> > + esac])
>
>The very elaborate list (of the original code, which you propose to
>restore) raises the impression of being target at exactly those
>versions, and IMO that is wrong.
>
>
IBM docs say that support for large files is available in AIX 4.2 and up. I
believe that was the reason for the version list in large_file.m4.
Though listing the versions does not look to me like claiming support for
_all_ those versions, how about leaving the version list as is and adding a
clarification in the comment?
# Large file support on AIX is available starting from version 4.2
# Tested only on 5.2 and up
aix4.[2-9]* | aix4.1[0-9]* | aix[5-9].* | aix[1-9][0-9]*)
ac_cv_sys_large_files=1 ;;
Best regards,
--
Alexey Kopytov, Software Developer
MySQL AB, www.mysql.com
Are you MySQL certified? www.mysql.com/certification
