Re: bk commit into 5.1 tree (mattiasj:1.2568) BUG#30695

[Ingo Strüwing]

Hi Mattias,

Ingo Strüwing, 11.10.2007 10:31:
...
> mattiasj@stripped, 10.10.2007 20:53:
...
>>   NOTE: If the comment is written by an earlier version of the server,
>>   the corrupted frm-file is still corrupt, drop the table and recreate it.
>>   (If needed, edit the frm-file manually and replace the apostrophe
>>   within the comment with a space to allow parsing)
> 
> Is this comment correct? Don't you fix the crash by below code?

Ahrg. I did not read the comment careful enough. Sorry. :-(

Now I suggest to change it for more clarity (IMHO):

... the corrupted frm-file is not fixed, but left corrupt. You have to
manually drop the table and recreate it.

I am a bit sceptical about public advice to edit a form file. If using
an inappropriate editor, this may have unpredictable results. Also it is
quite improbable that such table could have data. As far as I understand
there is no server version which could successfully open such a file. So
it could not add data to it. Drop and recreate shouldn't hurt much under
these circumstances.

Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140