Re: bk commit into 5.1 tree (mattiasj:1.2568) BUG#30695

[Ingo Strüwing]

Hi Mattias,

mattiasj@stripped, 10.10.2007 20:53:
...
> ChangeSet@stripped, 2007-10-10 20:53:29+02:00, mattiasj@mattiasj-laptop.(none) +4 -0
>   Bug #30695: An apostrophe ' in the comment of the ADD PARTITION
>     causes the Server to crash.
...
>   NOTE: If the comment is written by an earlier version of the server,
>   the corrupted frm-file is still corrupt, drop the table and recreate it.
>   (If needed, edit the frm-file manually and replace the apostrophe
>   within the comment with a space to allow parsing)

Is this comment correct? Don't you fix the crash by below code?

...
> diff -Nrup a/sql/table.cc b/sql/table.cc
> --- a/sql/table.cc	2007-08-31 11:55:53 +02:00
> +++ b/sql/table.cc	2007-10-10 20:53:28 +02:00
> @@ -1782,7 +1782,8 @@ int open_table_from_share(THD *thd, TABL
>                                  outparam, is_create_table,
>                                  share->default_part_db_type,
>                                  &work_part_info_used);
> -    outparam->part_info->is_auto_partitioned= share->auto_partitioned;
> +    if (!tmp)
> +      outparam->part_info->is_auto_partitioned= share->auto_partitioned;

Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140