List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:October 6 2007 9:52am
Subject:Re: bk commit into 5.2 tree (acurtis:1.2595) BUG#31149
View as plain text  
Hi!

On Oct 05, antony@stripped wrote:
> ChangeSet@stripped, 2007-10-05 09:01:44-07:00, acurtis@stripped +35 -0
>   Bug#31149
>     "Warnings and Error messages printed multiple times"
>     Many things may result in duplicate error messages which would give user no
> additional
>     information. These messages may be result of different phases of the same action
>     (prepare to do action vs executing action) or as consequence of similar but not
>     identical tests.
>     If a message is pushed and later another identical message but with a higher
> level
>     is pushed, the existing message has its level upgraded. For all duplicates, the
>     warn_count property is incremented so no information is lost but we do not do
> anything
>     with this property yet.

No, there could be a valid case when some warning is generated many
times (for different events, of course), such as

CREATE TABLE t2 (a varchar(30000), b varchar(30000), index(a), index(b));

So, please, instead of adding |uniq for warnings, although it's an
original idea, ensure that a "key was too long" warning is *generated*
only once.
 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.2 tree (acurtis:1.2595) BUG#31149antony5 Oct
  • Re: bk commit into 5.2 tree (acurtis:1.2595) BUG#31149Sergei Golubchik6 Oct