Hi Mattias,
Ok to push from me. But please see below for future improvements.
mattiasj@stripped, 04.10.2007 14:56:
...
> ChangeSet@stripped, 2007-10-04 14:56:33+02:00, mattiasj@mattiasj-laptop.(none) +3 -0
> Bug #30484: Partitions: crash with self-referencing trigger
>
> Two cases in ha_partition::extra() was missing
> (HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH)
> which only is currently used by NDB (which not uses ha_partition)
For this simple problem the description is ok. But usually we want to
see here:
1. What was the problem (short repetition of the bug report and/or high
level result of analyze),
2. How was it solved (high level description of the fix).
> mysql-test/r/partition.result@stripped, 2007-10-04 14:56:29+02:00,
> mattiasj@mattiasj-laptop.(none) +4 -0
> Added result for test of Bug #30484
We do not have a rule for specifying the bug in every file comment. But
for my taste it is welcome. However, in my humble opinion, it is better
to always add the bug title where a bug number is mentioned.
Again this is just my opinion. No need to change.
...
Regards
Ingo
--
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140
