Re: bk commit into 5.0 tree (gshchepa:1.2535) BUG#31077

[Sergei Golubchik]

Hi!

On Oct 03, Gleb Shchepa wrote:
> Sergei Golubchik wrote:
> >On Oct 01, gshchepa@stripped wrote:
> >  
> >>ChangeSet@stripped, 2007-10-01 20:35:51+05:00, gshchepa@stripped +4 -0
> >>  Fixed bug #31077.
> >>  mysqldump adds the "-- Dump completed on YYYY-MM-DD hh:mm:ss"
> >>  string to the end of output if the --comments switch is on.  The
> >>  only way to suppress this line is to use --skip-comments/--compact
> >>  switch.
> >>  
> >try to rewrite a test case w/o grep (just put a complete output in the
> >result file, no need to grep for the last line) - to make test suite
> >portable it should not rely on external tools (I know it does now, it's
> >being fixed).
> >  
> Hmm... But I need to know, what is the last line of the dump: "-- Dump 
> completed" or "--Dump compeleted on ...".
> I can use tail(1) instead of grep(1), but I need something to look into 
> output stream or into result file.
> IMHO there is no way to do it without external tools.

As I wrote - simply remove grep from the test, you'll have the complete
dump in the result file, together with its last line, naturally.

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140