Re: bk commit into 5.0 tree (gshchepa:1.2535) BUG#31077

[Gleb Shchepa]

Hello Sergei,

Thank you for reviews! Please read my answer below.

Sergei Golubchik wrote:
> Hi!
>
> On Oct 01, gshchepa@stripped wrote:
>   
>> ChangeSet@stripped, 2007-10-01 20:35:51+05:00, gshchepa@stripped +4 -0
>>   Fixed bug #31077.
>>   mysqldump adds the "-- Dump completed on YYYY-MM-DD hh:mm:ss" string
>>   to the end of output if the --comments switch is on.
>>   The only way to suppress this line is to use --skip-comments/--compact
>>   switch.
>>   
>>   New switch has been added to the mysqldump client command line:
>>   --dump-date.
>>     
>
> the fix is ok.
>
> try to rewrite a test case w/o grep (just put a complete output in the
> result file, no need to grep for the last line) - to make test suite
> portable it should not rely on external tools (I know it does now, it's
> being fixed).
>   
Hmm... But I need to know, what is the last line of the dump: "-- Dump 
completed" or "--Dump compeleted on ...".
I can use tail(1) instead of grep(1), but I need something to look into 
output stream or into result file.
IMHO there is no way to do it without external tools.
>  
> Regards / Mit vielen Grüssen,
> Sergei
>
>   

Thank you,
Gleb.