bk commit into 5.2 tree (rafal:1.2602) BUG#30938

[rsomla]

Below is the list of changes that have just been committed into a local
5.2 repository of rafal. When rafal does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-10-02 15:30:45+02:00, rafal@quant.(none) +1 -0
  BUG#30938 (BACKUP DATABASE crashes server if a table with a unloaded 
  SE exists):
  
  In case of errors, e.g., when openning temporary tables, users could 
  appreciate more precise information about the cause of a problem. 
  However function open_temporary_table() used here doesn't provide such 
  information. When it does, we should improve the way we report errors
  from this function. This patch adds a comment to remind us about that.

  sql/backup/sql_backup.cc@stripped, 2007-10-02 15:30:41+02:00, rafal@quant.(none) +8 -0
    Comment added.

diff -Nrup a/sql/backup/sql_backup.cc b/sql/backup/sql_backup.cc
--- a/sql/backup/sql_backup.cc	2007-10-01 16:13:20 +02:00
+++ b/sql/backup/sql_backup.cc	2007-10-02 15:30:41 +02:00
@@ -911,6 +911,14 @@ Backup_info::Table_ref::Table_ref(const 
   const char *name= m_name.ptr();
   ::build_table_filename(path, sizeof(path), db, name, "", 0);
   m_table= ::open_temporary_table(thd, path, db, name, FALSE /* don't link to
thd->temporary_tables */);
+  
+  /*
+   Note: If table couldn't be opened (m_table==NULL), open_temporary_table() 
+   doesn't inform us what was the reason. This makes it difficult to give 
+   precise information in the error log. Currently we just say that table 
+   couldn't be opened. When error reporting is improved, we should try to do 
+   better than that.
+   */ 
   return m_table;
 }