List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:October 2 2007 3:13pm
Subject:Re: bk commit into 5.0 tree (gshchepa:1.2535) BUG#31077
View as plain text  
Hi!

On Oct 01, gshchepa@stripped wrote:
> ChangeSet@stripped, 2007-10-01 20:35:51+05:00, gshchepa@stripped +4 -0
>   Fixed bug #31077.
>   mysqldump adds the "-- Dump completed on YYYY-MM-DD hh:mm:ss" string
>   to the end of output if the --comments switch is on.
>   The only way to suppress this line is to use --skip-comments/--compact
>   switch.
>   
>   New switch has been added to the mysqldump client command line:
>   --dump-date.

the fix is ok.

try to rewrite a test case w/o grep (just put a complete output in the
result file, no need to grep for the last line) - to make test suite
portable it should not rely on external tools (I know it does now, it's
being fixed).
 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.0 tree (gshchepa:1.2535) BUG#31077gshchepa1 Oct
  • Re: bk commit into 5.0 tree (gshchepa:1.2535) BUG#31077Sergei Golubchik2 Oct
    • Re: bk commit into 5.0 tree (gshchepa:1.2535) BUG#31077Gleb Shchepa2 Oct
      • Re: bk commit into 5.0 tree (gshchepa:1.2535) BUG#31077Sergei Golubchik2 Oct