Re: bk commit into 5.1 tree (holyfoot:1.2579) BUG#30208

[Sergei Golubchik]

Hi!

On Sep 14, holyfoot@stripped wrote:
> ChangeSet@stripped, 2007-09-14 20:58:00+05:00, holyfoot@stripped +4 -0
>   Bug #30208 CREATE TABLE ...LIKE does not eccespt dbname.tablename:unknown
> database.
>   
>   CREATE TABLE LIKE supposed to create an exact copy of a table, and
>   that is difficult to implement with a virtual table that INFORMATION
>   SCHEMA tables.
>   So CREATE TABLE LIKE is_table is disabled
> 
> diff -Nrup a/sql/share/errmsg.txt b/sql/share/errmsg.txt
> --- a/sql/share/errmsg.txt	2007-07-18 00:36:41 +05:00
> +++ b/sql/share/errmsg.txt	2007-09-14 20:57:58 +05:00
> @@ -6105,3 +6105,6 @@ ER_EVENT_INVALID_CREATION_CTX
>  
>  ER_TRG_CANT_OPEN_TABLE
>    eng "Cannot open table for trigger `%-.64s`.`%-.64s`"
> +ER_SCHEMA_TABLE_CREATE_LIKE
> +  eng "Information schema table `%-.64s` cannot be used in CREATE TABLE LIKE"

You think the situation is so unique and special that it requires a
dedicated error message ? Why not use the general:

"Table 'information_schema.processlist' cannot be used in CREATE TABLE LIKE"

It's ER_TABLENAME_NOT_ALLOWED_HERE. Although this error message is too
specific now, it says "from one of the SELECTs", please remove these
words from it.

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140