From: Date: March 3 2006 10:26pm
Subject: bk commit into 5.0 tree (cmiller:1.2101) BUG#16859
List-Archive: http://lists.mysql.com/commits/3452
X-Bug: 16859
Message-Id: <20060303212644.7DE345C05D@zippy>

Below is the list of changes that have just been committed into a local
5.0 repository of cmiller. When cmiller does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2101 06/03/03 16:26:38 cmiller@zippy.(none) +3 -0
  Bug#16859 involves truncating column data at NUL characters.  Instead, the 
  client will now substitute spaces for NULs, so that the grid isn't messed up
  due to silently consumed NULs and that the full field is shown.

  mysql-test/t/mysql.test
    1.7 06/03/03 16:26:34 cmiller@zippy.(none) +5 -0
    Add a test. 

  mysql-test/r/mysql.result
    1.6 06/03/03 16:26:34 cmiller@zippy.(none) +7 -0
    Add a test.

  client/mysql.cc
    1.197 06/03/03 16:26:34 cmiller@zippy.(none) +47 -8
    For non-numbers, print each character at a time, instead of using the 
    fprintf() facility, which interprets an array of chars as a C string, which 
    is necessarily NUL terminated.  We mustn't terminate on NULs, and since we 
    know the length of the data, we needn't.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	cmiller
# Host:	zippy.(none)
# Root:	/home/cmiller/work/mysql/mysql-5.0.19-tbr

--- 1.196/client/mysql.cc	2006-02-13 16:38:06 -05:00
+++ 1.197/client/mysql.cc	2006-03-03 16:26:34 -05:00
@@ -185,6 +185,7 @@
 void tee_fputs(const char *s, FILE *file);
 void tee_puts(const char *s, FILE *file);
 void tee_putc(int c, FILE *file);
+static void tee_print_sized_data(const char *data, unsigned int length, unsigned int width);
 /* The names of functions that actually do the manipulation. */
 static int get_options(int argc,char **argv);
 static int com_quit(String *str,char*),
@@ -2308,20 +2309,29 @@
     for (uint off= 0; off < mysql_num_fields(result); off++)
     {
       const char *str= cur[off] ? cur[off] : "NULL";
+      uint currlength;
+      uint maxlength;
+      uint numcells;
+
       field= mysql_fetch_field(result);
-      uint maxlength= field->max_length;
+      maxlength= field->max_length;
+      currlength= (uint) lengths[off];
+      numcells= charset_info->cset->numcells(charset_info, 
+                                                    str, str + currlength);
       if (maxlength > MAX_COLUMN_LENGTH)
       {
-	tee_fputs(str, PAGER);
-	tee_fputs(" |", PAGER);
+        tee_print_sized_data(str, currlength, maxlength);
+        tee_fputs(" |", PAGER);
       }
       else
       {
-        uint currlength= (uint) lengths[off];
-        uint numcells= charset_info->cset->numcells(charset_info, 
-                                                    str, str + currlength);
-        tee_fprintf(PAGER, num_flag[off] ? "%*s |" : " %-*s|",
-                    maxlength + currlength - numcells, str);
+        if (num_flag[off] != 0)
+          tee_fprintf(PAGER, " %-*s|", maxlength + currlength - numcells, str);
+        else 
+        {
+          tee_print_sized_data(str, currlength, maxlength);
+          tee_fputs(" |", PAGER);
+        }
       }
     }
     (void) tee_fputs("\n", PAGER);
@@ -2329,6 +2339,35 @@
   tee_puts((char*) separator.ptr(), PAGER);
   my_afree((gptr) num_flag);
 }
+
+
+static void
+tee_print_sized_data(const char *data, unsigned int length, unsigned int width)
+{
+  /* 
+    It is not a number, so print each character justified to the left.
+    For '\0's print ASCII spaces instead, as '\0' is eaten by (at
+    least my) console driver, and that messes up the pretty table
+    grid.  (The \0 is also the reason we can't use fprintf() .) 
+  */
+  unsigned int i;
+  const char *p;
+
+  tee_putc(' ', PAGER);
+
+  for (i= 0, p= data; i < length; i+= 1, p+= 1)
+  {
+    if (*p == '\0')
+      tee_putc((int)' ', PAGER);
+    else
+      tee_putc((int)*p, PAGER);
+  }
+
+  i+= 1; 
+  for (   ; i < width; i+= 1)
+    tee_putc((int)' ', PAGER);
+}
+
 
 
 static void

--- 1.5/mysql-test/r/mysql.result	2006-02-09 09:23:03 -05:00
+++ 1.6/mysql-test/r/mysql.result	2006-03-03 16:26:34 -05:00
@@ -69,3 +69,10 @@
 ソ
 ソ
 ソ
++----------------------+------------+--------+
+| concat('>',col1,'<') | col2       | col3   |
++----------------------+------------+--------+
+| >a   <               | b          | 123421 |
+| >a   <               | 0123456789 | 4      |
+| >abcd<               |            | 4      |
++----------------------+------------+--------+

--- 1.6/mysql-test/t/mysql.test	2006-02-24 11:34:08 -05:00
+++ 1.7/mysql-test/t/mysql.test	2006-03-03 16:26:34 -05:00
@@ -56,3 +56,8 @@
 --exec $MYSQL --default-character-set=utf8 test -e "charset cp932; set character_set_client= cp932; select 'ƒ\'"
 --exec $MYSQL --default-character-set=utf8 test -e "/*charset cp932 */; set character_set_client= cp932; select 'ƒ\'"
 --exec $MYSQL --default-character-set=utf8 test -e "/*!\C cp932 */; set character_set_client= cp932; select 'ƒ\'"
+
+#
+# Bug#16859 -- NULLs in columns must not truncate data as if a C-language "string".
+#
+--exec $MYSQL -t test -e "create table t1 (col1 binary(4), col2 varchar(10), col3 int); insert into t1 values ('a', 'b', 123421),('a ', '0123456789', 4), ('abcd', '', 4); select concat('>',col1,'<'), col2, col3 from t1; drop table t1;" 2>&1