From: Date: March 3 2006 6:08pm
Subject: bk commit into 5.0 tree (cmiller:1.2101) BUG#16859
List-Archive: http://lists.mysql.com/commits/3443
X-Bug: 16859
Message-Id: <20060303170820.57E575C05D@zippy>

Below is the list of changes that have just been committed into a local
5.0 repository of cmiller. When cmiller does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2101 06/03/03 12:08:13 cmiller@zippy.(none) +3 -0
  Bug#16859 involves truncating column data at NUL characters.  Instead, the client will now
  substitute spaces for NULs, so that the grid isn't messed up due to silently consumed NULs 
  and that the full field is shown.

  mysql-test/t/mysql.test
    1.7 06/03/03 12:08:09 cmiller@zippy.(none) +7 -0
    Add a test.  Use the verbose flags to get the full table-ified data from the client.

  mysql-test/r/mysql.result
    1.6 06/03/03 12:08:09 cmiller@zippy.(none) +33 -0
    Add a test.

  client/mysql.cc
    1.197 06/03/03 12:08:09 cmiller@zippy.(none) +31 -4
    For non-numbers, print each character at a time, instead of using the fprintf() facility,
    which interprets an array of chars as a C string, which is necessarily NUL terminated.
    We mustn't terminate on NULs, and since we know the length of the data, we needn't.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	cmiller
# Host:	zippy.(none)
# Root:	/home/cmiller/work/mysql/mysql-5.0.19-tbr

--- 1.196/client/mysql.cc	2006-02-13 16:38:06 -05:00
+++ 1.197/client/mysql.cc	2006-03-03 12:08:09 -05:00
@@ -2312,16 +2312,43 @@
       uint maxlength= field->max_length;
       if (maxlength > MAX_COLUMN_LENGTH)
       {
-	tee_fputs(str, PAGER);
-	tee_fputs(" |", PAGER);
+        tee_fputs(str, PAGER);
+        tee_fputs(" |", PAGER);
       }
       else
       {
         uint currlength= (uint) lengths[off];
         uint numcells= charset_info->cset->numcells(charset_info, 
                                                     str, str + currlength);
-        tee_fprintf(PAGER, num_flag[off] ? "%*s |" : " %-*s|",
-                    maxlength + currlength - numcells, str);
+        if (num_flag[off] != 0)
+          tee_fprintf(PAGER, " %-*s|", maxlength + currlength - numcells, str);
+        else 
+        { 
+          /* It is not a number, so print each character justified to the left.
+           * For '\0's print ASCII spaces instead, as '\0' is eaten by (at
+           * least my) console driver, and that messes up the pretty table
+           * grid.  (The \0 is also the reason we can't use fprintf() .) */
+          unsigned int i;
+          const char *p;
+
+          tee_putc(' ', PAGER);
+
+          for (i = 0, p = str; i < currlength; i += 1, p += 1)
+          {
+            if (*p == '\0')
+              tee_putc((int)' ', PAGER);
+            else
+              tee_putc((int)*p, PAGER);
+          }
+
+          i += 1;  /* I don't know why. */
+          for ( /**/; i < maxlength; i += 1)
+            tee_putc((int)' ', PAGER);
+
+          tee_putc(' ', PAGER);
+          tee_putc('|', PAGER);
+        }
+
       }
     }
     (void) tee_fputs("\n", PAGER);

--- 1.5/mysql-test/r/mysql.result	2006-02-09 09:23:03 -05:00
+++ 1.6/mysql-test/r/mysql.result	2006-03-03 12:08:09 -05:00
@@ -69,3 +69,36 @@
 ソ
 ソ
 ソ
+--------------
+create table t1 (col1 binary(4), col2 varchar(10), col3 int)
+--------------
+
+Query OK, 0 rows affected (0.01 sec)
+
+--------------
+insert into t1 values ('a', 'b', 123421),('a ', '0123456789', 4), ('abcd', '0123456789', 4)
+--------------
+
+Query OK, 3 rows affected (0.00 sec)
+Records: 3  Duplicates: 0  Warnings: 0
+
+--------------
+select concat('>',col1,'<'), col2, col3 from t1
+--------------
+
++----------------------+------------+--------+
+| concat('>',col1,'<') | col2       | col3   |
++----------------------+------------+--------+
+| >a   <               | b          | 123421 |
+| >a   <               | 0123456789 | 4      |
+| >abcd<               | 0123456789 | 4      |
++----------------------+------------+--------+
+3 rows in set (0.00 sec)
+
+--------------
+drop table t1
+--------------
+
+Query OK, 0 rows affected (0.00 sec)
+
+Bye

--- 1.6/mysql-test/t/mysql.test	2006-02-24 11:34:08 -05:00
+++ 1.7/mysql-test/t/mysql.test	2006-03-03 12:08:09 -05:00
@@ -56,3 +56,10 @@
 --exec $MYSQL --default-character-set=utf8 test -e "charset cp932; set character_set_client= cp932; select 'ƒ\'"
 --exec $MYSQL --default-character-set=utf8 test -e "/*charset cp932 */; set character_set_client= cp932; select 'ƒ\'"
 --exec $MYSQL --default-character-set=utf8 test -e "/*!\C cp932 */; set character_set_client= cp932; select 'ƒ\'"
+
+#
+# Bug#16859 -- NULLs in columns must not truncate data as if a C-language "string".
+#
+#  This uses three verbose flags so that the output is rendered using the
+#  functions that had the problem.
+--exec $MYSQL -v -v -v test -e "create table t1 (col1 binary(4), col2 varchar(10), col3 int); insert into t1 values ('a', 'b', 123421),('a ', '0123456789', 4), ('abcd', '0123456789', 4); select concat('>',col1,'<'), col2, col3 from t1; drop table t1;" 2>&1