List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:September 7 2007 4:03pm
Subject:Re: bk commit into 5.1 tree (thek:1.2589) BUG#30887
View as plain text  
* kpettersson@stripped <kpettersson@stripped> [07/09/07 19:07]:
> ChangeSet@stripped, 2007-09-07 16:11:55+02:00, thek@adventure.(none) +2 -0
>   Bug #30887 Server crashes on SET GLOBAL query_cache_size=0
>   
>   Reseting the query cache by issuing a SET GLOBAL query_cache_size=0 would
>   cause the server to crash if a the server was saving a new result set to the
>   query cache.

Could you please explain how this patch will prevent FLUSH threads
starvation?


>     - Refactored query_cache_end_of_result to rely on block level locks instead
>       of global lock.

Let's not take any extra risk in 5.1 unless you have to do that.
OK to push this piece into 5.2 (after review).

>     - Added reference variable counting active writers.
>     - Fixed bug for embedded access which doesn't support grant privileges.

Please fix it in a separate patch, if possible (so that it can be
approved quickly).

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY
Thread
bk commit into 5.1 tree (thek:1.2589) BUG#30887kpettersson7 Sep
  • Re: bk commit into 5.1 tree (thek:1.2589) BUG#30887Konstantin Osipov7 Sep
  • Re: bk commit into 5.1 tree (thek:1.2589) BUG#30887Konstantin Osipov27 Sep