Re: bk commit into 5.1 tree (skozlov:1.2564) BUG#29020

[Magnus Svensson]

Hi Serge,

only one comment about why you have disabled the cleanup of the files
generated in $MYSQLTEST_VARDIR/tmp

Please put them back and change the "--exec rm <file>" to "remove_file
<file>"(a mysqltest builtin command).

mån 2007-08-27 klockan 18:44 +0400 skrev Serge Kozlov:
> ChangeSet@stripped, 2007-08-27 18:44:13+04:00, skozlov@stripped +3 -0
>   WL#3694 Replication of Invocation and Invoked Features Testing.
>   Bug#29020 Event results not correctly replicated to slave in RBR: partially.
> 

<snip>

> @@ -260,13 +280,12 @@ UPDATE t13 SET c='';
>  
>  # Remove dumps
>  --echo
> ---exec rm $MYSQLTEST_VARDIR/tmp/rpl_invoked_features_master.sql
> ---exec rm $MYSQLTEST_VARDIR/tmp/rpl_invoked_features_slave.sql
> +#--exec rm $MYSQLTEST_VARDIR/tmp/rpl_invoked_features_master.sql
> +#--exec rm $MYSQLTEST_VARDIR/tmp/rpl_invoked_features_slave.sql

^Here!!
>  
>  # Remove tables,views,procedures,functions
>  --connection master
>  --echo
> ---disable_warnings
>  DROP VIEW IF EXISTS v1,v11;
>  DROP TABLE IF EXISTS t1,t2,t3,t11,t12,t13;
>  DROP PROCEDURE IF EXISTS p1;
> @@ -275,7 +294,6 @@ DROP FUNCTION IF EXISTS f1;
>  DROP FUNCTION IF EXISTS f2;
>  DROP EVENT IF EXISTS e1;
>  DROP EVENT IF EXISTS e11;
> ---enable_warnings
>  
>  --sync_slave_with_master slave
>  
> 

I also recommend running 
$> ./mtr rpl_invoked_feature --check-testcase
so you see that all the objects created has been dropped.



/ Magnus

-- 
Magnus Svensson
Senior Software Engineer
msvensson@stripped
[phone]