bk commit into 5.0 tree (ramil:1.2094) BUG#17615

[ramil]

Below is the list of changes that have just been committed into a local
5.0 repository of ram. When ram does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2094 06/03/02 15:05:55 ramil@stripped +3 -0
  Fix for bug #17615: invalid handling of function results in UPDATE...SET statement.

  sql/item_func.cc
    1.274 06/03/02 15:05:42 ramil@stripped +2 -0
    Fix for bug #17615: invalid handling of function results in UPDATE...SET statement.
    - set proper collation

  mysql-test/t/sp.test
    1.178 06/03/02 15:05:42 ramil@stripped +23 -0
    Fix for bug #17615: invalid handling of function results in UPDATE...SET statement.

  mysql-test/r/sp.result
    1.189 06/03/02 15:05:42 ramil@stripped +14 -0
    Fix for bug #17615: invalid handling of function results in UPDATE...SET statement.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	ramil
# Host:	myoffice.izhnet.ru
# Root:	/usr/home/ram/work/5.0.b17615

--- 1.273/sql/item_func.cc	2006-02-07 16:21:41 +04:00
+++ 1.274/sql/item_func.cc	2006-03-02 15:05:42 +04:00
@@ -4881,6 +4881,7 @@ Item_func_sp::fix_length_and_dec()
   {
     decimals= result_field->decimals();
     max_length= result_field->field_length;
+    collation.set(result_field->charset());
     DBUG_VOID_RETURN;
   }
 
@@ -4891,6 +4892,7 @@ Item_func_sp::fix_length_and_dec()
   }
   decimals= field->decimals();
   max_length= field->field_length;
+  collation.set(field->charset());
   maybe_null= 1;
   delete field;
   DBUG_VOID_RETURN;

--- 1.188/mysql-test/r/sp.result	2006-02-24 20:34:08 +04:00
+++ 1.189/mysql-test/r/sp.result	2006-03-02 15:05:42 +04:00
@@ -4768,4 +4768,18 @@ Handler
 Inner
 drop procedure bug15011|
 drop table t3|
+drop function if exists bug17615|
+create table t3 (a varchar(256) unicode)|
+create function bug17615() returns varchar(256) unicode
+begin
+declare tmp_res varchar(256) unicode;
+set tmp_res= 'foo string';
+return tmp_res;
+end|
+insert into t3 values(bug17615())|
+select * from t3|
+a
+foo string
+drop function bug17615|
+drop table t3|
 drop table t1,t2;

--- 1.177/mysql-test/t/sp.test	2006-02-24 20:34:08 +04:00
+++ 1.178/mysql-test/t/sp.test	2006-03-02 15:05:42 +04:00
@@ -5616,6 +5616,29 @@ drop table t3|
 
 
 #
+# BUG#17615: problem with character set
+#
+--disable_warnings
+drop function if exists bug17615|
+--enable_warnings
+
+create table t3 (a varchar(256) unicode)|
+
+create function bug17615() returns varchar(256) unicode
+begin
+  declare tmp_res varchar(256) unicode;
+  set tmp_res= 'foo string';
+  return tmp_res;
+end|
+
+insert into t3 values(bug17615())|
+select * from t3|
+
+drop function bug17615|
+drop table t3|
+
+
+#
 # BUG#NNNN: New bug synopsis
 #
 #--disable_warnings