From: Konstantin Osipov
Date: September 3 2007 10:22pm
Subject: Re: bk commit into 5.2 tree (markleith:1.2598) BUG#25822
List-Archive: http://lists.mysql.com/commits/33603
Message-Id: <20070903222253.GN9569@bodhi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

* Mark Leith <mleith@stripped> [07/09/04 02:22]:
> ChangeSet@stripped, 2007-09-03 23:18:50+01:00, markleith@stripped +1 -0
>   Bug#25822 / WL#3953 - Log Access Denied errors for bad passwords in the error log
>   

OK to push.

>   Added logging of Access Denied messages on failed new connections to the 
>   error log when log-warnings = 2.
>   
>   This allows a user to log these messages without having to incur the overhead
>   of using the general query log on production systems.
> 
>   sql/sql_connect.cc@stripped, 2007-09-03 23:18:44+01:00, markleith@stripped +12 -0
>     Added logging of Access Denied messages to error log when log-warnings=2
> 
> diff -Nrup a/sql/sql_connect.cc b/sql/sql_connect.cc
> --- a/sql/sql_connect.cc	2007-07-30 09:33:44 +01:00
> +++ b/sql/sql_connect.cc	2007-09-03 23:18:44 +01:00
> @@ -502,6 +502,18 @@ int check_user(THD *thd, enum enum_serve
>                      thd->main_security_ctx.user,
>                      thd->main_security_ctx.host_or_ip,
>                      passwd_len ? ER(ER_YES) : ER(ER_NO));
> +  /* 
> +    log access denied messages to the error log when log-warnings = 2
> +    so that the overhead of the general query log is not required to track 
> +    failed connections 
> +  */

Please start the comment from a capital letter and end with a dot.

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY