Re: bk commit into 5.0 tree (davi:1.2502) BUG#30632

[Paul DuBois]

At 2:04 AM +0400 8/27/07, Konstantin Osipov wrote:
>* Davi Arnaut <davi@stripped> [07/08/25 03:48]:
>>  ChangeSet@stripped, 2007-08-24 20:25:43-03:00, davi@stripped +3 -0
>>    Bug#30632 HANDLER read failure causes hang
>>  
>>    If, after the tables are locked, one of the conditions to read 
>>from a HANDLER table is not met, the handler code wrongly jumps to 
>>a error path that won't unlock the tables.
>
>What was the user-visible effect of the bug? It's somewhat
>deducible from the bug's synopsis, but please make Docs' team job
>a bit easier by adding a description that they could use for the
>changelog comment.

Hear, hear! :-)

Davi, it'll also make your job easier, because if we (docs) cannot tell
what the changelog entry should be, we'll just set the bug back to Need
Doc Info status and ask you for a description.  A good description
eliminates that step for everyone.

>   
>>    The fix is simply to correct the code to jump to the (same) 
>>error path that unlocks the tables.
>>
>
>80-column rule is applicable here, too.
>
>>       if ((keyno=find_type(keyname, &table->s->keynames, 1+2)-1)<0)
>>       {
>>         my_error(ER_KEY_DOES_NOT_EXITS, MYF(0), keyname, tables->alias);
>>  -      goto err0;
>>  +      goto err;
>>       }
>>     }
>OK to push.
>
>--
>-- Konstantin Osipov              Software Developer, Moscow, Russia
>-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY
>
>--
>MySQL Code Commits Mailing List
>For list archives: http://lists.mysql.com/commits
>To unsubscribe:    http://lists.mysql.com/commits?unsub=1


-- 
Paul DuBois, MySQL Documentation Team
Madison, Wisconsin, USA
MySQL AB, www.mysql.com