From: Date: August 27 2007 3:40pm
Subject: bk commit into 5.1 tree (tomas:1.2577) BUG#29549
List-Archive: http://lists.mysql.com/commits/33151
X-Bug: 29549
Message-Id: <20070827134055.63599180E8064@linux.local>

Below is the list of changes that have just been committed into a local
5.1 repository of tomas. When tomas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-08-27 15:40:49+02:00, tomas@stripped +2 -0
  Bug#29549 rpl_ndb_myisam2ndb,rpl_ndb_innodb2ndb failed on Solaris for pack_length issue

  mysql-test/suite/rpl_ndb/t/disabled.def@stripped, 2007-08-27 15:40:47+02:00, tomas@stripped +2 -2
    Bug#29549 rpl_ndb_myisam2ndb,rpl_ndb_innodb2ndb failed on Solaris for pack_length issue

  sql/field.cc@stripped, 2007-08-27 15:40:47+02:00, tomas@stripped +17 -1
    - always pack in little endian, irrespective of starage engine native format
    - always unpack as if it is atored in little endian, and unpack it to storage engine native format

diff -Nrup a/mysql-test/suite/rpl_ndb/t/disabled.def b/mysql-test/suite/rpl_ndb/t/disabled.def
--- a/mysql-test/suite/rpl_ndb/t/disabled.def	2007-07-29 20:04:00 +02:00
+++ b/mysql-test/suite/rpl_ndb/t/disabled.def	2007-08-27 15:40:47 +02:00
@@ -14,8 +14,8 @@
 rpl_ndb_2innodb          : BUG#19227 2006-04-20 pekka pk delete apparently not replicated
 rpl_ndb_2myisam          : BUG#19227 Seems to pass currently
 rpl_ndb_dd_partitions    : BUG#19259 2006-04-21 rpl_ndb_dd_partitions fails on s/AMD
-rpl_ndb_innodb2ndb       : Bug#29549 rpl_ndb_myisam2ndb,rpl_ndb_innodb2ndb failed on Solaris for pack_length issue
-rpl_ndb_myisam2ndb       : Bug#29549 rpl_ndb_myisam2ndb,rpl_ndb_innodb2ndb failed on Solaris for pack_length issue
+#rpl_ndb_innodb2ndb       : Bug#29549 rpl_ndb_myisam2ndb,rpl_ndb_innodb2ndb failed on Solaris for pack_length issue
+#rpl_ndb_myisam2ndb       : Bug#29549 rpl_ndb_myisam2ndb,rpl_ndb_innodb2ndb failed on Solaris for pack_length issue
 rpl_ndb_ddl              : BUG#28798 2007-05-31  lars  Valgrind failure in NDB
 rpl_ndb_mix_innodb       : BUG#28123 rpl_ndb_mix_innodb.test casue slave to core on sol10-sparc-a
 rpl_ndb_ctype_ucs2_def   : BUG#27404 util thd mysql_parse sig11 when mysqld default multibyte charset
diff -Nrup a/sql/field.cc b/sql/field.cc
--- a/sql/field.cc	2007-08-13 21:39:23 +02:00
+++ b/sql/field.cc	2007-08-27 15:40:47 +02:00
@@ -7622,6 +7622,13 @@ uchar *Field_blob::pack(uchar *to, const
     ptr= (uchar*) from;
   }
   else
+#ifdef WORDS_BIGENDIAN
+  if (table->s->db_low_byte_first)
+  {
+    store_length(to,packlength,length,0);
+  }
+  else
+#endif
     memcpy(to,from,packlength);			// Copy length
   if (length)
   {
@@ -7658,8 +7665,17 @@ const uchar *Field_blob::unpack(uchar *t
 
 const uchar *Field_blob::unpack(uchar *to, const uchar *from)
 {
-  memcpy(to,from,packlength);
   uint32 length=get_length(from);
+#ifdef WORDS_BIGENDIAN
+  if (table->s->db_low_byte_first)
+  {
+    store_length(to,packlength,length,1);
+  }
+  else
+#endif
+  {
+    memcpy(to,from,packlength);
+  }
   from+=packlength;
   if (length)
     memcpy_fixed(to+packlength, &from, sizeof(from));