Konstantin Osipov wrote:
> * Mats Kindahl <mats@stripped> [07/08/16 10:56]:
>
>> ChangeSet@stripped, 2007-08-16 08:52:50+02:00, mats@stripped +11
> -0
>> Renaming MASTER_INFO to Master_info in order to follow the coding
>> standards (and help Doxygen generating good documentation).
>>
>
> OK to push.
>
> Please see unrelated comment below.
>
>
>> - class MASTER_INFO *mi;
>> + /* parent Master_info structure */
>> + class Master_info *mi;
>>
>
> I noticed that this noise word ("class" or "struct") can get
> doxygen confused too.
>
> E.g. if declaration contains:
>
> void foo(class Bar *bar);
>
>
> and definition is:
>
> void foo(Bar *bar)
> {
> ...
> }
>
>
> doxygen wouldn't always be able to match declaration to
> definition.
>
OK. Good catch, I'll fix that as well while I'm at it.
> PS BTW, how do you do these renames?
> I normally use 'replace' command by Monty:
>
> bk edit *.{h,cc}
> replace MASTER_INFO Master_info -- *.{h,cc}
>
> It has one drawback, if it meets a symlink, it converts it to a
> hard copy.
>
I usually use grep-find from inside Emacs with a stupidly big find +
grep (that way, I get around symlinks) and combine it with a
query-replace. I'm going to write an Emacs-macro for it any day, but
haven't done it yet.
Just my few cents,
Mats Kindahl
--
Mats Kindahl
Lead Software Developer
Replication Team
MySQL AB, www.mysql.com
