List:Commits« Previous MessageNext Message »
From:Alexey Kopytov Date:August 15 2007 3:54pm
Subject:Re: bk commit into 5.0 tree (tsmith:1.2513) BUG#27694
View as plain text  
Timothy,

The patch looks good to me except the following typo:

On Wednesday 15 August 2007, tim@stripped wrote:
>@@ -821,30 +821,14 @@ sub get_raid_dirs {
> sub get_list_of_tables {
>     my ( $db ) = @_;
>
>-    # "use database" cannot cope with database names containing spaces
>-    # so create a new connection
>+    my $tables =
>+        eval {
>+            $dbh->selectall_arrayref('SHOW TABLES FRM ' .

SHOW TABLES FROM

>+                                     $dbh->quote_identifier($db))
>+        } || [];
>+    warn "Unable to retrieve list of tables in $db: $@" if $@;
>

Best regards,

-- 
Alexey Kopytov, Software Developer
MySQL AB, www.mysql.com

Are you MySQL certified?  www.mysql.com/certification
Thread
bk commit into 5.0 tree (tsmith:1.2513) BUG#27694tim15 Aug
  • Re: bk commit into 5.0 tree (tsmith:1.2513) BUG#27694Alexey Kopytov15 Aug
    • Re: bk commit into 5.0 tree (tsmith:1.2513) BUG#27694Timothy Smith15 Aug