Re: bk commit into 5.0 tree (cmiller:1.2500) BUG#15776

[Timothy Smith]

Chad,

Hi.  In your 2nd patch for bug #15776,

http://lists.mysql.com/commits/32411

I see that the behavior has changed for select year(2**32).  It fails
now with ER_TOO_BIG_FIELDLENGTH, where before it silently truncated to
4.  I can imagine that this is an OK change, but I wasn't expecting it.

Now with the change, the comment I asked for doesn't make sense to me:

+--error ER_TOO_BIG_FIELDLENGTH
+# It's probably okay if this fails for other than 2**31 overflow.
+CREATE TABLE t1 (a year(4294967296));


Now that it's failing like the others, a special comment isn't needed.
I think it's better to either:  preserve the old behavior (truncate to
4) and comment that this behavior is probably buggy, or throw an error
without a comment.


Normally I'd recommend against the behavior change, but this is really
obscure and I doubt anyone will run into it in production situations.

Regards,

Timothy
-- 
-- Timothy Smith       Team Lead, Maintenance; Dolores, Colorado, USA
-- MySQL, www.mysql.com      The best DATABASE COMPANY in the GALAXY!