Re: bk commit into 5.1 tree (malff:1.2553) BUG#25422

[Konstantin Osipov]

* marc.alff@stripped <marc.alff@stripped> [07/07/27 10:33]:
> ChangeSet@stripped, 2007-07-27 00:31:06-06:00, malff@weblab.(none) +39 -0
>   WL#3984 (Revise locking of mysql.general_log and mysql.slow_log)
>   Bug#25422 (Hang with log tables)
>   Bug 17876 (Truncating mysql.slow_log in a SP after using cursor locks the
>             thread)
>   Bug 23044 (Warnings on flush of a log table)
>   Bug 29129 (Resetting general_log while the GLOBAL READ LOCK is set causes
>              a deadlock)

OK to push.

Please see if you can:
 * move the checks in mysql_lock_tables to a static function 
 * remove the change to flags of SQLCOM_ALTER_EVENT
 * use table->no_replicate (if you can't, add a note for Mats and
   push without)
 * move locking of MYSQL_QUERY_LOG::LOCK to MYSQL_QUERY_LOG::write

We should re-factor close_thread_tables to not reset THD::ha_data,
as it is now called for time zone tables, mysql.proc table, etc
(i.e. for on-demand open/close). When this is done,
close_performance_table can use it.
But this is not to be addressed now.

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY