Re: bk commit into 5.1 tree (gkodinov:1.2556) BUG#30000

[Sergei Golubchik]

Hi!

On Jul 27, Georgi Kodinov wrote:
> On 26.07.2007, at 19:35, Sergei Golubchik wrote:
> >On Jul 25, kgeorge@stripped wrote:
> >>ChangeSet@stripped, 2007-07-25 16:56:49+03:00, gkodinov@stripped  +3 -0
> >>  Bug #30000: SHOW commands once again ends up in the slow query log
> >>
> >>  All SHOW commands must not enter the slow query log.
> >>
> >>  Extended the 5.1 fix for bug 19764 to cover all the SHOW commands
> >>  (instead of only SHOW STATUS). This makes it compatible with the
> >>  5.0 behavior.
> 
> <skip>
> 
> >Your patch will work, but don't you think the code is getting more
> >unmaintainable and fragile that way - every show command need to
> >remember to reset these flags in thd->server_status.
> >
> >I'd prefer a different solution:
...

> This is indeed the more natural way of fixing the bug. But it also  
> introduces overhead that Monty wanted to avoid : hence the fix for  
> 5.1 is different from the one in 5.0. See Monty's comments in bug  
> #19764 (dated [19 Jun 2006 11:08]).

Come on, this is ridiculous. This adds few CPU instructions that will be
executed only for a show command of a slow query.
 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Radlkoferstr. 2, D-81373 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140