Re: bk commit into 5.1 tree (anozdrin:1.2560) BUG#30029

[Konstantin Osipov]

* Alexander Nozdrin <alik@stripped> [07/07/26 12:05]:

> ChangeSet@stripped, 2007-07-26 11:54:07+04:00, anozdrin@ibm. +1 -0
>   Fix for BUG#30029: mysql_upgrade fails for 5.0 -> 5.1.21,
>   5.1.20 -> 5.1.21 upgrades.
>   
>   We generate mysql_fix_privilege.sql file, which contains SQL
>   statements required to upgrade the system database. This script
>   is generated by concatenation of mysql_system_tables.sql and
>   mysql_system_tables_fix.sql.
>   
>   The problem was that
>     - in order to create general_log and slow_log tables we use
>       stored programs in mysql_system_tables.sql;
>     - we upgrade mysql.proc table in mysql_system_tables_fix.sql;
>   
>   So, if mysql.proc table needs to be upgraded, stored procedures
>   can not be used in mysql_system_tables.sql.
>   
>   In other words, in mysql_system_tables.sql stored programs must
>   not be used because they may be unavailable at this point.
>   
>   The fix is to use dynamic SQL instead of stored programs.
> 
>   scripts/mysql_system_tables.sql@stripped, 2007-07-26 11:54:05+04:00, anozdrin@ibm. +13
> -8
>     Use dynamic SQL instead of stored programs.

Please write a comment why there is no test case.

OK to push.

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY