Re: bk commit into 5.2 tree (cmiller:1.2550) BUG#13174

[Joerg Bruehe]

Hi Chad,


I fear your patch is incomplete:


Chad MILLER wrote:
> [[...]]
> 
> ChangeSet@stripped, 2007-07-24 13:04:53-04:00, cmiller@stripped +12 -0
>   Bug#13174: SHA2 function
>   
>   [[...]]
> 
>   include/sha2.h@stripped, 2007-07-24 13:04:51-04:00, cmiller@stripped +58 -0
>     Compatibility layer to make YaSSL behave like OpenSSL.
> 
>   include/sha2.h@stripped, 2007-07-24 13:04:51-04:00, cmiller@stripped +0 -0

This is a new header file, right ?

That means you need to include it in the list of files a "make dist" 
will put into the source tarball, or else it will be missing there.

So please modify "include/Makefile.am" accordingly.

> 
>   libmysqld/CMakeLists.txt@stripped, 2007-07-24 13:04:51-04:00,
> cmiller@stripped +1 -1
>     Add new file to source list.
> 
>   libmysqld/Makefile.am@stripped, 2007-07-24 13:04:51-04:00, cmiller@stripped
> +2 -0
>     Include standard DEFS in embedded compilation.

Doesn't that introduce a circular dependency ?

Also, that part looked like lacking a line continuation character,
does it really work ?

>     
>     Add new file to source list.
> 
>   [[...]]
> 
>   sql/Makefile.am@stripped, 2007-07-24 13:04:51-04:00, cmiller@stripped +1 -1
>     Add new file to source list.

Yes, I see it as a source.
However, I did not check whether it also is included in the "dist" target.

> [[...]]


To check, please do this, with appropriate (different) values for 
DIR_EXP and DIR_PLAT :

   bk export -w $DIR_EXP

   cd $DIR_EXP
   BUILD/compile-dist
   make dist
   cp mysql-[45.]*.tar.gz $DIR_PLAT

   cd $DIR_PLAT
   tar xzvf mysql-[45.]*.tar.gz
   ./configure --with-your-options
   make


If you need that more often, I can mail you my script from which I 
extracted the above lines.


Regards,
Jörg

-- 
Joerg Bruehe, Senior Production Engineer
MySQL AB, www.mysql.com
Office:  ([phone]     VoIP: 4464@stripped