Re: bk commit into 5.0 tree (evgen:1.2535) BUG#29856

[Konstantin Osipov]

* eugene@stripped <eugene@stripped> [07/07/24 03:02]:
> ChangeSet@stripped, 2007-07-23 18:10:12+04:00, evgen@stripped +3 -0
>   Bug#29856: Insufficient buffer space led to a server crash.
>   
>   The subst_spvars function is used to create query string with SP variables 
>   substituted with their values. This string is used later for the binary log
>   and for the query cache. The problem is that the
>   query_cache_send_result_to_client function requires some additional space
>   after the query to store database name and query cache flags. This 
>   space wasn't reserved by the subst_spvars function which led to a memory
>   corruption and crash.

Just for your information: in 5.1 I fixed it differently, by not
storing query cache flags in thd->query.

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY