Re: bk commit into 5.0 tree (gshchepa:1.2527) BUG#29834

[Konstantin Osipov]

* gshchepa@stripped <gshchepa@stripped> [07/07/20 04:03]:
> Below is the list of changes that have just been committed into a local
> 5.0 repository of uchum. When uchum does a push these changes will
> be propagated to the main repository and, within 24 hours after the
> push, to the public repository.
> For information on how to access the public repository
> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
> 
> ChangeSet@stripped, 2007-07-20 04:49:29+05:00, gshchepa@stripped +3 -0
>   Fixed bug #29834.
>   Repetitive access to the view column by it's name in a stored
>   procedure caused a memory leak.


The check for thd->spcont is wrong.
Please use an existing API with change_arena_if_needed().

And please explain what condition you're checking for,
semantically, in the changeset comment.

> +      if (register_tree_change && !thd->spcont)
>          arena= thd->activate_stmt_arena_if_needed(&backup);

:/

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY