* Ingo Strüwing <ingo@stripped> [07/07/19 12:26]:
> OK to push from me. Please see suggestions for improvement below.
Thank you Ingo, I fixed according to your comments and pushed.
> > As a side note, the whole concept of two locks - LOCK_delayed_insert
> > and LOCK_delayed_create is redundant,
> Agree. But is a changeset the right place to add such note? Wouldn't a
> TODO comment in the code be more appropriate? Or a worklog entry/feature
> request?
Done.
>
> I would like to add the confusing naming of variables. We should always
> call a Delayed_insert object 'di', not 'tmp'.
Done, this can't destabilize anything, so I just fixed that.
--
-- Konstantin Osipov Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com The best DATABASE COMPANY in the GALAXY
