From: Date: July 18 2007 9:22pm
Subject: bk commit into 5.1 tree (acurtis:1.2555) BUG#29875
List-Archive: http://lists.mysql.com/commits/31120
X-Bug: 29875
Message-Id: <200707181922.l6IJMLke026988@mail.mysql.com>

Below is the list of changes that have just been committed into a local
5.1 repository of antony. When antony does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-07-18 12:22:05-07:00, acurtis@stripped +3 -0
  Bug#29875
    "Disable transaction support in Federated storage engine"
    Minimal patch to disable Federated's transactions until they can be fixed.

  mysql-test/t/disabled.def@stripped, 2007-07-18 12:22:02-07:00, acurtis@stripped +1 -0
    bug29875
      disable federated_transactions test until Bug#29523 is resolved.

  storage/federated/ha_federated.cc@stripped, 2007-07-18 12:22:02-07:00, acurtis@stripped +11 -0
    bug29875
      Disable support for transactions until fixed.

  storage/federated/ha_federated.h@stripped, 2007-07-18 12:22:02-07:00, acurtis@stripped +1 -0
    bug29875
      Disable support for transactions until fixed.

diff -Nrup a/mysql-test/t/disabled.def b/mysql-test/t/disabled.def
--- a/mysql-test/t/disabled.def	2007-07-17 01:20:30 -07:00
+++ b/mysql-test/t/disabled.def	2007-07-18 12:22:02 -07:00
@@ -25,4 +25,5 @@ ctype_big5               : BUG#26711 200
 
 mysql_upgrade        : Bug#28560 test links to /usr/local/mysql/lib libraries, causes non-determinism and failures on ABI breakage
 federated_innodb     : Bug#29522 failed assertion in binlog_close_connection()
+federated_transactions   : Bug#29523 Transactions do not work
 lowercase_table3     : Bug#29839 2007-07-17 ingo Cannot find table test/T1 from the internal data dictionary
diff -Nrup a/storage/federated/ha_federated.cc b/storage/federated/ha_federated.cc
--- a/storage/federated/ha_federated.cc	2007-06-30 09:17:08 -07:00
+++ b/storage/federated/ha_federated.cc	2007-07-18 12:22:02 -07:00
@@ -449,6 +449,12 @@ int federated_db_init(void *p)
   federated_hton->create= federated_create_handler;
   federated_hton->flags= HTON_ALTER_NOT_SUPPORTED | HTON_NO_PARTITION;
 
+  /*
+    Support for transactions disabled until WL#2952 fixes it.
+  */
+  federated_hton->commit= 0;
+  federated_hton->rollback= 0;
+
   if (pthread_mutex_init(&federated_mutex, MY_MUTEX_INIT_FAST))
     goto error;
   if (!hash_init(&federated_open_tables, &my_charset_bin, 32, 0, 0,
@@ -3163,6 +3169,10 @@ int ha_federated::external_lock(THD *thd
   ha_federated *trx= (ha_federated *)thd->ha_data[ht->slot];
   DBUG_ENTER("ha_federated::external_lock");
 
+  /*
+    Support for transactions disabled until WL#2952 fixes it.
+  */
+#ifdef XXX_SUPERCEDED_BY_WL2952
   if (lock_type != F_UNLCK)
   {
     DBUG_PRINT("info",("federated not lock F_UNLCK"));
@@ -3216,6 +3226,7 @@ int ha_federated::external_lock(THD *thd
       }
     }
   }
+#endif /* XXX_SUPERCEDED_BY_WL2952 */
   DBUG_RETURN(0);
 }
 
diff -Nrup a/storage/federated/ha_federated.h b/storage/federated/ha_federated.h
--- a/storage/federated/ha_federated.h	2007-06-30 09:17:08 -07:00
+++ b/storage/federated/ha_federated.h	2007-07-18 12:22:02 -07:00
@@ -141,6 +141,7 @@ public:
             | HA_REC_NOT_IN_SEQ | HA_AUTO_PART_KEY | HA_CAN_INDEX_BLOBS |
             HA_BINLOG_ROW_CAPABLE | HA_BINLOG_STMT_CAPABLE |
             HA_NO_PREFIX_CHAR_KEYS | HA_PRIMARY_KEY_REQUIRED_FOR_DELETE |
+            HA_NO_TRANSACTIONS /* until fixed by WL#2952 */ |
             HA_PARTIAL_COLUMN_READ | HA_NULL_IN_KEY);
   }
   /*