List:Commits« Previous MessageNext Message »
From:Ingo Strüwing Date:July 18 2007 6:57pm
Subject:Re: bk commit into 5.0 tree (cmiller:1.2503) BUG#26909
View as plain text  
Chad MILLER wrote:
...
> ChangeSet@stripped, 2007-07-12 15:11:49-04:00, cmiller@stripped +3 -0
>   Bug#26909: Specified key was too long; max key length is 255 bytes \
>   	when creating table
>   
>   Federated tables have an artificially low maximum of key length, 
>   because the handler fails to implement a method to return it and 
>   the default value is taked from the prototype handler.
...
> -  uint max_supported_key_length()    const { return MAX_KEY_LENGTH; }
> +  uint max_supported_key_length()    const { return FEDERATED_MAX_KEY_LENGTH; }
> +  uint max_supported_key_part_length() const { return FEDERATED_MAX_KEY_LENGTH; }

Ok. Next time I will wait a week after being asked to review. Just to
see if more changes come in.

Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Radlkoferstr. 2, D-81373 München
Geschäftsführer: Kaj Arnö - HRB München 162140
Thread
bk commit into 5.0 tree (cmiller:1.2503) BUG#26909Chad MILLER12 Jul
  • Re: bk commit into 5.0 tree (cmiller:1.2503) BUG#26909Ingo Strüwing18 Jul
    • Re: bk commit into 5.0 tree (cmiller:1.2503) BUG#26909Chad MILLER18 Jul
      • Re: bk commit into 5.0 tree (cmiller:1.2503) BUG#26909Ingo Strüwing19 Jul