Hi Chad,
nice fix. Ok to push from me with small changes. Please see below.
Chad MILLER wrote:
...
> ChangeSet@stripped, 2007-07-12 13:46:13-04:00, cmiller@stripped +3 -0
> Bug#26909: Specified key was too long; max key length is 255 bytes \
> when creating table
>
> Federated tables have an artificially low maximum of key length.
Please write this sentence in past tense. Please do also tell what the
problem was (default implementation of max_supported_key_part_length()
returned 255), and how it was solved (re-implemented
max_supported_key_part_length() with MAX_KEY_LENGTH). I had to figure
this out from the code. That might be the burden that a reviewer (and
all interested developers in the community) has to carry, but we should
not load it on the docs team.
...
> --- 1.35/mysql-test/t/federated.test 2006-11-29 13:56:18 -05:00
> +++ 1.36/mysql-test/t/federated.test 2007-07-12 13:46:12 -04:00
...
> +#
> +# Bug#26909: Specified key was too long; max key length is 255 bytes when create
> table
Please try to avoid lines > 80 chars in test files.
...
> +CREATE TABLE federated.t1 (
...
> +eval CREATE TABLE federated.t1 (
...
> +
> +connection master;
> +drop table federated.t1;
> +
> +connection slave;
> +drop table federated.t1;
Wouldn't it be nice to see if it works with data (INSERT + SELECT by
using key)? I agree that the bug report was about failing CREATE, but
what does a successful CREATE help, if DML fails? (I believe it will not
be a problem, but shouldn't we prove it?)
...
Regards
Ingo
--
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Radlkoferstr. 2, D-81373 München
Geschäftsführer: Kaj Arnö - HRB München 162140
