Re: [NDB patch 5/5] BUG#28804 Dbtc::releaseAbortResources() send returnsignal when exists.

[Jonas Oreland]

stewart@stripped wrote:
> On failing to seize space in saveINDXATTRINFO, we need to send a reply
> back to API that we've aborted the txn.
> 
> Previously we wouldn't send the reply, and the ultra-long timeout
> waiting for reply in NdbTransaction would be hit.
> 
> This enables "instant" rollback and application notification.
> 
> ===== ndb/src/kernel/blocks/dbtc/DbtcMain.cpp 1.110 vs edited =====
> Index: ndb-work/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp
> ===================================================================
> --- ndb-work.orig/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp	2007-07-12
> 12:43:51.161095427 +1000
> +++ ndb-work/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp	2007-07-12 12:43:54.941310849
> +1000
> @@ -11782,6 +11782,8 @@ bool Dbtc::saveINDXKEYINFO(Signal* signa
>      ptrCheckGuard(apiConnectptr, capiConnectFilesize, apiConnectRecord);
>      releaseIndexOperation(apiConnectptr.p, indexOp);
>      terrorCode = 4000;
> +    if(TcKeyReq::getExecuteFlag(indexOp->tcIndxReq.requestInfo))
> +      apiConnectptr.p->m_exec_flag= 1;
>      abortErrorLab(signal);
>      return false;
>    }
> 
> --
> Stewart Smith
> 
> 

at the very least, this should also be added to Dbtc::saveINDXATTRINFO
most likely more places...