List:Commits« Previous MessageNext Message »
From:Georgi Kodinov Date:July 11 2007 11:30am
Subject:Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325
View as plain text  
On 11.07.2007, at 13:59, Konstantin Osipov wrote:

> * Georgi Kodinov <kgeorge@stripped> [07/07/11 13:24]:
>>> 18:33:07 <serg> joro: hey, I wasn't serious when I said
>>>                 "dont-overwrite-files-if-data-directory-is-current-
>>> database"
>>>                 :) That was an attempt to clarify the semantics,
>>> *not* a
>>>                 suggestion to have an option with the name that  
>>> long!
>>>
>>> Please, rename it to something decent, about 20-30 characters long
>>> The patch itself is good
>>> ok to push but for heavens sake, rename this variable :)
>>
>> Done: renamed to "keep_files_on_create". Otherwise one would have had
>> problems spelling out this option :-)
>>
>
> myisam_keep_files_on_create maybe?

Kostja, serg described this option as not engine specific (it is as  
of now, but may be reused) : hence I haven't prefixed it with myisam_.

Best Regards,
Joro
-- 
Georgi Kodinov, Senior Software Engineer
MySQL AB, Plovdiv, Bulgaria, www.mysql.com
Office: +359 32 634 397 Mobile: +359 887 700 566 Skype: georgekodinov

Are you MySQL certified?  www.mysql.com/certification


Thread
bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325kgeorge6 Jul
  • Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325Sergei Golubchik10 Jul
    • Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325Georgi Kodinov11 Jul
      • Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325Konstantin Osipov11 Jul
        • Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325Georgi Kodinov11 Jul