List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:July 10 2007 5:06pm
Subject:Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325
View as plain text  
Hi!

On Jul 06, kgeorge@stripped wrote:
> ChangeSet@stripped, 2007-07-06 18:57:51+03:00, gkodinov@stripped +9 -0
>   Bug #29325: 
>   By default MyISAM overwrites .MYD and .MYI files no 
>   DATA DIRECTORY option is used. This can lead to two tables
>   using the same .MYD and .MYI files (that can't be dropped).
>   
>   To prevent CREATE TABLE from overwriting a file a new option
>   is introduced : 
>   dont_overwrite_files_if_data_directory_is_current_database

you apparently didn't see what I wrote on IRC the moment when I saw your
patch (on Jul 6):

18:33:07 <serg> joro: hey, I wasn't serious when I said
                "dont-overwrite-files-if-data-directory-is-current-database"
                :) That was an attempt to clarify the semantics, *not* a
                suggestion to have an option with the name that long!

Please, rename it to something decent, about 20-30 characters long
The patch itself is good
ok to push but for heavens sake, rename this variable :)

>   When this is on the CREATE TABLE throws an error if either
>   the .MYD or .MYI exists for a MyISAM table.
>   The option is off by default (resulting in compatible behavior).
> 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Radlkoferstr. 2, D-81373 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325kgeorge6 Jul
  • Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325Sergei Golubchik10 Jul
    • Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325Georgi Kodinov11 Jul
      • Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325Konstantin Osipov11 Jul
        • Re: bk commit into 5.0 tree (gkodinov:1.2521) BUG#29325Georgi Kodinov11 Jul