Stewart Smith write:
> On Fri, 2007-07-06 at 11:57 +0800, Guangbao Ni wrote:
>
>> Stewart Smith Write:
>>
>>> On Thu, 2007-07-05 at 17:12 +0800, Guangbao Ni wrote:
>>>
>>>
>>>> +void Dblqh::execSTART_LCPIMME_CONF(Signal* signal)
>>>> +{
>>>> + jamEntry();
>>>> + lcpStartImmeResponded = true;
>>>> + return;
>>>> +}
>>>>
>>>>
>>> Should we reset lcpStartImmeResponded at end of LCP instead?
>>>
>>>
>>>
>> no, lcpStartImmeResponded here just means that the master DIH has
>> received the START_LCPIMME_REQ.
>>
>>> Otherwise (i think) we could keep sending START_LCPIMME_REQ while one is
>>> already ongoing if we keep filling up the log?
>>>
>>>
>>>
>> This is a good question. I have considered it.
>> when LCP is already ongoing it can't keep sending STAR_LCPIMME_REQ.
>> Because if lcp is going, then
>> clcpCompletedState != LCP_IDLE. Only if clcpCompletedState == LCP_IDLE,
>> STAR_LCPIMME_REQ signal can be sent
>>
>
> Okay, missed that :) good.
>
>
>>> Also, I think it should be reset on master failure so we send to new
>>> master.
>>>
>>>
>>>
>> Right, I will add the code.
>>
>
> (will be good to have test case for this too)
>
Tomas told that the ERROR_INSERT can only be worked in debug mode.
So i still can't know how to add it. :-)
Do you have another suggestion to add a test case?
Thanks!
/Guangbao Ni
