bk commit into 6.0-falcon tree (jas:1.2587)

[U-ROWVWADEjas]

Below is the list of changes that have just been committed into a local
6.0-falcon repository of . When  does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-07-05 12:28:10-04:00, jas@rowvwade. +2 -0
  Changed Transaction::releaseDependency to remove dependency on
  accurate return of interlocked decrement value.

  storage/falcon/Transaction.cpp@stripped, 2007-07-05 12:27:59-04:00, jas@rowvwade. +5 -3
    Changed Transaction::releaseDependency to remove dependency on
    accurate return of interlocked decrement value.

  storage/falcon/Transaction.h@stripped, 2007-07-05 12:28:00-04:00, jas@rowvwade. +1 -0
    Changed Transaction::releaseDependency to remove dependency on
    accurate return of interlocked decrement value.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jas
# Host:	rowvwade.
# Root:	D:/MySQL/mysql-5.1-falcon

--- 1.105/storage/falcon/Transaction.cpp	2007-07-05 12:28:29 -04:00
+++ 1.106/storage/falcon/Transaction.cpp	2007-07-05 12:28:29 -04:00
@@ -147,6 +147,7 @@
 				{
 				transaction->addRef();
 				INTERLOCKED_INCREMENT(transaction->dependencies);
+				transaction->cleanupNeeded = 1;
 				TransState *state = states + numberStates;
 				state->transaction = transaction;
 				state->transactionId = transaction->transactionId;
@@ -1082,10 +1083,11 @@
 	ASSERT(useCount >= 2);
 	ASSERT(dependencies > 0);
 	ASSERT(state != Available);
-	int count = INTERLOCKED_DECREMENT(dependencies);
+	INTERLOCKED_DECREMENT(dependencies);
 
-	if ((count == 0) && !writePending)
-		commitRecords();
+	if ((dependencies == 0) && !writePending)
+		if (COMPARE_EXCHANGE(&cleanupNeeded, (INTERLOCK_TYPE) 1, (INTERLOCK_TYPE) 0))
+			commitRecords();
 		
 	releaseCommittedTransaction();
 }

--- 1.53/storage/falcon/Transaction.h	2007-07-05 12:28:29 -04:00
+++ 1.54/storage/falcon/Transaction.h	2007-07-05 12:28:29 -04:00
@@ -167,6 +167,7 @@
 	volatile INTERLOCK_TYPE	dependencies;
 	volatile INTERLOCK_TYPE	useCount;
 	volatile INTERLOCK_TYPE	inList;
+	volatile INTERLOCK_TYPE	cleanupNeeded;
 
 protected:
 	RecordVersion	*records;